Skip to content

yes: don't mix buffered write and zero-copy#12294

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:yes-raw
May 20, 2026
Merged

yes: don't mix buffered write and zero-copy#12294
sylvestre merged 1 commit into
uutils:mainfrom
oech3:yes-raw

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 14, 2026 •
edited
Loading

No need to double buffering.
Buffered write after zero-copy does not cause any breakage. But it is a risk of changing order of outputs when tried to improve fallback in the future (I'm planning to do that) by mixing them.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026 •
edited
Loading

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/date/date-locale-hour (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/rm/isatty (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/tail/tail-n0f is now being skipped but was previously passing.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented May 14, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 317 untouched benchmarks
⏩ 46 skipped benchmarks1

Comparing oech3:yes-raw (a0ffa5e) with main (dfd6297)2

Open in CodSpeed

Footnotes

  1. 46 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (ab328d1) during the generation of this report, so dfd6297 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@oech3 oech3 marked this pull request as ready for review May 14, 2026 17:28
sylvestre
sylvestre approved these changes May 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — avoids potential output ordering issues by consistently using RawWriter.

@sylvestre sylvestre merged commit ef5155a into uutils:main May 20, 2026
171 checks passed
@oech3 oech3 deleted the yes-raw branch May 20, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@oech3 @sylvestre